Wireshark-commits: [Wireshark-commits] master 8a0673a: Bluetooth: nordic: Document RSSI sample resu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 11:05:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a0673a5787f886e742fbeee4b7c793eeecbf264
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8a0673a by Joakim Andersson (joakim.andersson@xxxxxxxxxxxxx):

    Bluetooth: nordic: Document RSSI sample result in the nordic_ble dissector
    
    Document the RSSI sample result in the nordic_ble dissector. This value is
    directly from the RSSISAMPLE register which is a positive number. It must
    be converted to negative value.
    Change to using INT8 because the RSSISAMPLE is only 7 bits value, and will
    always be a positive number.
    
    Change-Id: I7f0ad74b3e30ffecade59b6d0c5965bfc634531a
    Signed-off-by: Joakim Andersson <joakim.andersson@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36784
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  b6e4b38   Bluetooth: Dissect the common extendend advertising payload header
     add  8a0673a   Bluetooth: nordic: Document RSSI sample result in the nordic_ble dissector


Summary of changes:
 epan/dissectors/packet-nordic_ble.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)