Wireshark-commits: [Wireshark-commits] master-3.0 36e5266: Add record length checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Apr 2020 22:44:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36e5266fe751415f9e41e28552a593d8b060ae9c
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

36e5266 by Guy Harris (guy@xxxxxxxxxxxx):

    Add record length checks.
    
    Make sure the summary record is large enough; if not, report it as a bad
    file.
    
    If it's *too* large, skip the added data.
    
    Clean up the length check for the header records - use sizeof, as we
    later use sizeof when subtracting the fixed length portion's length.
    
    Change-Id: I70697804eaa0cbbb1fb074eadf6457d237f26876
    Reviewed-on: https://code.wireshark.org/review/36814
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit ada1a5c770e00d087385e2ec870291d67e190959)
    Reviewed-on: https://code.wireshark.org/review/36816
    

Actions performed:

    from  a06033c   Fix a comment.
     add  36e5266   Add record length checks.


Summary of changes:
 wiretap/lanalyzer.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)