Wireshark-commits: [Wireshark-commits] master-3.0 eb0680d: tshark: fix use-after-free while closing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 08 Apr 2020 21:59:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb0680d0b4660ea7a3fc543da3826b8730b83c61
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

eb0680d by Peter Wu (peter@xxxxxxxxxxxxx):

    tshark: fix use-after-free while closing a live capture file
    
    wtap_cleanup() clears options which are still in use by the time
    cf_close calls wtap_close. Be sure to close the capture file first.
    
    Bug: 16487
    Change-Id: Id9ef1c0321865e9574b69439870a842efb2b209b
    Fixes: v3.3.0rc0-853-g3662a69036 ("Maintain cf->state, because file cleanup depends on it.")
    Reviewed-on: https://code.wireshark.org/review/36755
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit a0600e02a9a5fa02531ca3c2d5a2d82b325aab1c)
    Reviewed-on: https://code.wireshark.org/review/36757
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  74140e2   Build 3.0.10.
     add  eb0680d   tshark: fix use-after-free while closing a live capture file


Summary of changes:
 tshark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)