Wireshark-commits: [Wireshark-commits] master-3.2 7517350: FPP: Make dissector directionally aware
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7517350f53bf8a9da512292b67d0454c84c602f0
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
7517350 by Jaap Keuter (jaap.keuter@xxxxxxxxx):
FPP: Make dissector directionally aware
The IEEE 802.3br dissector does good work figuring out when a frame is
preempted by another, in the same direction, and reassemble the continuation
into a proper Ethernet frame. But when, at the same time, a frame appears in
the other direction, not unheard of in a full duplex link, the reassembly is
thrown in turmoil.
This change makes the reassembly directionally aware, so that preemptions,
either way and even simultanious, can be distinguised as long as the
direction of the frame is known.
Bug: 16470
Change-Id: Ic99353c1b95238e0d63c4cd14cd454d09e3675cc
Reviewed-on: https://code.wireshark.org/review/36731
Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit ecebc071ad7ea5482147d88a27dc97df5dc7c355)
Reviewed-on: https://code.wireshark.org/review/36733
Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
Actions performed:
from 4738fec BACapp: Add a nesting / recursion check.
add 7517350 FPP: Make dissector directionally aware
Summary of changes:
epan/dissectors/packet-fpp.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)