Wireshark · Wireshark-commits: [Wireshark-commits] master 13d5615: gsm_map: Dissect location number with the ISUP dissect function

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13d5615db9bbcccc213b5255926992bc4bed7ba5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

13d5615 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    gsm_map: Dissect location number with the ISUP dissect function
    
    There are at least two problems with the previous implemenation:
    
    - The odd/even indicator was not used when dissecting the digits and
    an additional 0 was displayed when location number has odd number of
    digits.
    - For International Numbers the correct NA is 4 and not 3 (national) and
    for national numbers an incorrect country code is displayed.
    
    Change-Id: If5bb143642205eab762fbccae28f131af28d89c0
    Reviewed-on: https://code.wireshark.org/review/36720
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ef717da   CMake: remove ENABLE_PCAP_NG_DEFAULT option
     add  13d5615   gsm_map: Dissect location number with the ISUP dissect function


Summary of changes:
 epan/dissectors/asn1/gsm_map/gsm_map.cnf           |  21 +---
 .../asn1/gsm_map/packet-gsm_map-template.c         |  82 -------------
 epan/dissectors/packet-gsm_map.c                   | 131 +++------------------
 3 files changed, 16 insertions(+), 218 deletions(-)