Wireshark-commits: [Wireshark-commits] master e97ba4b: TN5250: Fix issue with range_string entry hi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 04 Apr 2020 09:35:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e97ba4b48955d455d80011d0b8bc739adce32755
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e97ba4b by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    TN5250: Fix issue with range_string entry hiding those below.
    
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PIP See Through On":  520093697 0x1f000001 -> 520093697 0x1f000001)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PIP SeeThrough Off":  520093696 0x1f000000 -> 520093696 0x1f000000)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Freeze PIP":  536870913 0x20000001 -> 536870913 0x20000001)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Resume After Freeze":  536870912 0x20000000 -> 536870912 0x20000000)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PC/TV Channel":  301989888 0x12000000 -> 301989988 0x12000064)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set Antenna Tuner Source":  285212672 0x11000000 -> 285212672 0x11000000)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set Cable Tuner Source":  285212673 0x11000001 -> 285212673 0x11000001)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Disable Internal Speaker":  553648129 0x21000001 -> 553648129 0x21000001)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Enable Internal  Speaker":  553648128 0x21000000 -> 553648128 0x21000000)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Keyboard Disable":  385875969 0x17000001 -> 385875969 0x17000001)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Keyboard Enable":  385875968 0x17000000 -> 385875968 0x17000000)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PC/TV Brightness":  218103808 0xd000000 -> 218103908 0xd000064)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PC/TV Color":  251658240 0xf000000 -> 251658340 0xf000064)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PC/TV Contrast":  234881024 0xe000000 -> 234881124 0xe000064)
    value_range_string error:  Video/Audio Control Data (tn5250.vac_data) hidden by earlier entry (prev="Set PIP Location and Size":  0 0x0 -> 4294967295 0xffffffff)  (this="Set PC/TV Tint":  268435456 0x10000000 -> 268461156 0x10006464)
    value_range_string error:  Data Field (tn5250.dfdpck_data_field) hidden by earlier entry (prev="Invalid Data Field Type":  0 0x0 -> 64 0x40)  (this="Top Row Command Key Functions":  64 0x40 -> 64 0x40)
    
    Change-Id: I3596fa1a62c6f0e7c115551be137162ddb6679a6
    Reviewed-on: https://code.wireshark.org/review/36683
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  c474b70   github: move pip installations upwards.
     add  e97ba4b   TN5250: Fix issue with range_string entry hiding those below.


Summary of changes:
 epan/dissectors/packet-tn5250.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)