Wireshark-commits: [Wireshark-commits] master ec2ca11: Clean up a number of things.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec2ca11c9c5e13bc1ba8cea5944ad6d02c3147d7
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
ec2ca11 by Guy Harris (guy@xxxxxxxxxxxx):
Clean up a number of things.
Pass to the routines that handle particular ISIS PDU types a tvbuff for
the *full* PDU; some PDU types may have a checksum CLV type that
checksums the *entire* PDU.
Pass an isis_data_t * around to various routines, rather than passing
some individual bits of information around.
Add to that structure:
the PDU length from the common-to-all-PDU-types part of the ISIS
header;
a proto_item * for the header length field;
an expert_field * for a "the header length is bad" error.
Use the PDU length from that structure when handling the aforementioned
checksum CLV.
When dissecting the PDU-type-specific part of the ISIS header, check to
make sure we're not going past the header length and, if we are, report
it with an expert info, using the header length field proto_item * and
expert_field * from that structure.
Show the type field in sub-TLVs of the Group Address TLV (RFC 7176
section 2.1) and, if the type is unknown, add a top-level item with the
type and length fields under it.
This fixes some bugs.
Bug: 16477
Change-Id: I875306d9d4fd8f65a60b7a6d3be7e356afabe851
Reviewed-on: https://code.wireshark.org/review/36671
Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
Actions performed:
from a2b3b0d usbll: fix no previous prototype for function
add ec2ca11 Clean up a number of things.
Summary of changes:
epan/dissectors/packet-isis-clv.c | 16 +-
epan/dissectors/packet-isis-clv.h | 6 +-
epan/dissectors/packet-isis-hello.c | 141 +++++++++++------
epan/dissectors/packet-isis-lsp.c | 302 ++++++++++++++++++++++--------------
epan/dissectors/packet-isis-snp.c | 157 ++++++++++++-------
epan/dissectors/packet-isis.c | 21 ++-
epan/dissectors/packet-isis.h | 3 +
7 files changed, 408 insertions(+), 238 deletions(-)
