Wireshark-commits: [Wireshark-commits] master 71e9009: Check for true_false_string with identical t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 Apr 2020 10:32:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71e9009825db727fd84f7cbc9cc278df988188b9
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

71e9009 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Check for true_false_string with identical true/false string.
    
    Fixed a few instances where fix were obvious, others are
    less clear.
    The check in proto.c is protected by ENABLE_CHECK_FILTER.
    
    Change-Id: I4edee4e67bd53bbf2eb809d68c87983a7c5a66f3
    Reviewed-on: https://code.wireshark.org/review/36645
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  9b7a54d   Make the message type values hex.
     add  71e9009   Check for true_false_string with identical true/false string.


Summary of changes:
 epan/dissectors/asn1/ansi_map/packet-ansi_map-template.c |  2 +-
 epan/dissectors/packet-ansi_map.c                        |  2 +-
 epan/dissectors/packet-aoe.c                             |  7 ++-----
 epan/dissectors/packet-per.c                             | 12 ++----------
 epan/dissectors/packet-smb.c                             |  2 +-
 epan/dissectors/packet-tn5250.c                          |  3 ++-
 epan/proto.c                                             | 14 ++++++++++++++
 7 files changed, 23 insertions(+), 19 deletions(-)