Wireshark-commits: [Wireshark-commits] master 30bad8e: Have callback function pointers in a capture
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 23:16:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30bad8e627ad087bd905ea29ba832d79f2fc5f63
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

30bad8e by Guy Harris (guy@xxxxxxxxxxxx):

    Have callback function pointers in a capture_session structure.
    
    Instead of having programs that use the capchild library define
    functions with known names, with the library routines calling back
    routines with those names, have function pointers for those callbacks in
    the capture_session structure, and have capture_session_init() set them.
    
    Make the callback routines in TShark and in the ui library static.
    
    Change-Id: Ia1ba6119c5ef7708e0f87b8420f200136ba41eae
    Reviewed-on: https://code.wireshark.org/review/36583
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  3662a69   Maintain cf->state, because file cleanup depends on it.
     add  30bad8e   Have callback function pointers in a capture_session structure.


Summary of changes:
 capchild/capture_session.h | 66 +++++++++++++++++++++++++++++++++++++++++++---
 capchild/capture_sync.c    | 26 ++++++++++++------
 capchild/capture_sync.h    | 47 ---------------------------------
 tshark.c                   | 33 ++++++++++++++++-------
 ui/capture.c               | 29 +++++++++++++-------
 ui/capture.h               | 11 +++++++-
 ui/qt/main_window.cpp      |  2 +-
 7 files changed, 135 insertions(+), 79 deletions(-)