Wireshark · Wireshark-commits: [Wireshark-commits] master 12d5041: Qt: Fix Lua GUI issues and get rid of casts.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12d5041eb7cbd5b28567ac58b140864561fadccd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

12d5041 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix Lua GUI issues and get rid of casts.
    
    Define a FunnelStatistics dtor and use it to clear our funnel
    operations. This keeps us from crashing if we quit while a ProgDlg or
    TextWindow is visible.
    
    In FunnelStatistics::progressDialogNew, pass in our parent MainWindow
    instead of depending on capture_file_ having a valid window pointer.
    This lets us use a ProgDlg without having to load a capture file.
    
    Define and use the _funnel_ops_id_t struct so that we don't have to cast
    void pointers in a bunch of places.
    
    Change-Id: I38dd3f254b705ddf82f7421a14d27b8c3ef7bc98
    Reviewed-on: https://code.wireshark.org/review/36538
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  21ed54a   RDMnet
     add  12d5041   Qt: Fix Lua GUI issues and get rid of casts.


Summary of changes:
 ui/qt/funnel_statistics.cpp | 65 ++++++++++++++++++++++++++-------------------
 ui/qt/funnel_statistics.h   |  3 +++
 2 files changed, 40 insertions(+), 28 deletions(-)