Wireshark-commits: [Wireshark-commits] master d854143: NAS-5GS: shift supi_fmt field before testing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2020 10:40:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d854143e8fa49aea130a0dfa995fe7466076b7c8
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d854143 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    NAS-5GS: shift supi_fmt field before testing
    
    From cppcheck:
    epan/dissectors/packet-nas_5gs.c:749: style: Mismatching assignment and comparison, comparison 'supi_fmt==1' is always false.
    
    Change-Id: I702f0cae24fd95dc925a87ab3766f2995f3eb759
    Reviewed-on: https://code.wireshark.org/review/36554
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  9c28c92   USBLL: Handle addresses for all packets
     add  d854143   NAS-5GS: shift supi_fmt field before testing


Summary of changes:
 epan/dissectors/packet-nas_5gs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)