Wireshark-commits: [Wireshark-commits] master-3.2 706db7f: coap: use correct OSCORE option type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2020 03:34:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=706db7f0d1d7a171743522a99c5baeabb976b761
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

706db7f by Cenk Gündoğan (mail+dev@xxxxxxxxxxxx):

    coap: use correct OSCORE option type
    
    The current implementation assumes a wrong OSCORE option type
    "21". RFC 8613 was release in July 2019 and defines an OSCORE option
    type of "9". See: https://tools.ietf.org/html/rfc8613#section-2
    
    Change-Id: I5fea8dffc2d1586f891b2b3b9fa42183b138e0ab
    Reviewed-on: https://code.wireshark.org/review/35163
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5199a61e796ae10c036391d4f6c44fac1c4df18c)
    Reviewed-on: https://code.wireshark.org/review/36551
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  67c7761   RTCP: contain BYE packet dissection to its stated length
     add  706db7f   coap: use correct OSCORE option type


Summary of changes:
 epan/dissectors/packet-coap.c | 6 +++---
 epan/dissectors/packet-coap.h | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)