Wireshark-commits: [Wireshark-commits] master f998e78: RTCP: contain BYE packet dissection to its s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Mar 2020 14:52:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f998e785d5ead49c57ef282765519d4ae75e056e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f998e78 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    RTCP: contain BYE packet dissection to its stated length
    
    The Goodbye RTCP packet dissection has to derive whether the optional
    "Reason for leaving" string is present or not. This has to be derived
    from the length. When put into a compound RTCP packet, the length
    derivation from the TVB length does not work, because another RTCP
    packet may follow in this compound RTCP packet.
    
    With this change the stated length of this RTCP packet is passed to
    the RTCP BYE packet dissection function in order to make a proper
    length determination and not overrun into the next RTCP packet in the
    compound RTCP packet.
    
    Bug: 16434
    Change-Id: Iab0fdd52c745028a9928bbef6c731ff649213277
    Reviewed-on: https://code.wireshark.org/review/36532
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  428735c   [Automatic update for 2020-03-22]
     add  f998e78   RTCP: contain BYE packet dissection to its stated length


Summary of changes:
 epan/dissectors/packet-rtcp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)