Wireshark-commits: [Wireshark-commits] master-3.2 4cb8ce5: Qt: Add elements back to the tcptrace gr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Mar 2020 15:58:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4cb8ce52c45dfb4fc61befe6bd72b0dee3ae4853
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

4cb8ce5 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add elements back to the tcptrace graph.
    
    Segment and SACK elements in the tcptrace graph are plotted using
    QCustomPlot's error bars. This part of QCP's API changed from version 1
    to 2, and were #ifdef'ed out as part of the switch to QCP 2.0.1. Update
    our code to use the new API.
    
    Bug: 16281
    Change-Id: Ieae2808686ddc631e0cd18c0c32fc7a2c0f396b7
    Reviewed-on: https://code.wireshark.org/review/35726
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 999e63543fccc327f929329b7ae96164df492e92)
    Reviewed-on: https://code.wireshark.org/review/36449
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    

Actions performed:

    from  608e480   Remove unwanted newline.
     add  4cb8ce5   Qt: Add elements back to the tcptrace graph.


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp | 94 ++++++++++++++++++++++++++-------------------
 ui/qt/tcp_stream_dialog.h   |  3 ++
 2 files changed, 57 insertions(+), 40 deletions(-)