Wireshark-commits: [Wireshark-commits] master 1d20a87: Qt: Fix bug causing hidden columns to be dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2020 12:07:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d20a875e4a623dfd88cc9baf25555ecea202b33
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1d20a87 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix bug causing hidden columns to be displayed
    
    Set capture file for model and header before columnsChanged() is called
    to prevent skipping model reset in PacketListModel::resetColumns() due
    to cap_file_ being NULL.
    
    Do not strech last section in packet list header. This prevents
    QHeaderViewPrivate::resizeSections() from messing up the column sizes
    via resize events. For some reason (unknown to me) underlying
    QHeaderView implementation has different idea about the number of
    visible columns than our code.
    
    Ping-Bug: 16063
    Change-Id: I482c1080adb418b7922ee99d357d4962dc086026
    Reviewed-on: https://code.wireshark.org/review/36120
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  0039505   Tab stops are always always always always always every 8 spaces.
     add  1d20a87   Qt: Fix bug causing hidden columns to be displayed


Summary of changes:
 ui/qt/models/packet_list_model.cpp   | 1 -
 ui/qt/packet_list.cpp                | 6 +++---
 ui/qt/widgets/packet_list_header.cpp | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)