Wireshark-commits: [Wireshark-commits] master 9567bf0: packet-dis: fix dissection of Entity State U
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2020 06:09:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9567bf0595e256cbf211258578d3698b2e788212
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9567bf0 by Tony Ciavarella (tony.ciavarella@xxxxxxxxxxxxxxxxxxxxxx):

    packet-dis: fix dissection of Entity State Update PDUs
    
    The dissector for Distributed Interactive Simulation reports malformed packets
    for Entity State Update PDUs because the offset for the Number of Variable
    Records field is off-by-one.  The Padding field dissection is also off-by-one.
    
    This change fixes the problem by not incrementing the offset returned by the
    parseField_Entity function which is already past the Entity ID field.  The
    offset must be incremented after dissecting the Number of Variable Records
    field to get to the start of the Entity Linear Velocity.
    
    Change-Id: I942123be7a1d4e4e4fc587f757cb030a3daf8ef2
    Reviewed-on: https://code.wireshark.org/review/36420
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fd34c09   Remove an out-of-date comment.
     add  9567bf0   packet-dis: fix dissection of Entity State Update PDUs


Summary of changes:
 epan/dissectors/packet-dis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)