Wireshark-commits: [Wireshark-commits] master 598839f: dot11decrypt: Make ccmp_construct_aad an int
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Mar 2020 07:37:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=598839ff10b298f02080eb531c43d5f4f5553722
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

598839f by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Make ccmp_construct_aad an internal utility function
    
    The function to construct AAD is same for both CCMP and GCMP so move
    it to a new internal utility c file for later use by both
    implementations.
    
    Change-Id: I8c8ffe0f492d5860e2bcd266b4d936383598b47e
    Reviewed-on: https://code.wireshark.org/review/36358
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eed31f1   ieee80211: Add CCMP-256 decryption support
     add  598839f   dot11decrypt: Make ccmp_construct_aad an internal utility function


Summary of changes:
 epan/crypt/CMakeLists.txt      |  3 ++
 epan/crypt/dot11decrypt_ccmp.c | 63 ++----------------------------
 epan/crypt/dot11decrypt_util.c | 87 ++++++++++++++++++++++++++++++++++++++++++
 epan/crypt/dot11decrypt_util.h | 21 ++++++++++
 4 files changed, 114 insertions(+), 60 deletions(-)
 create mode 100644 epan/crypt/dot11decrypt_util.c
 create mode 100644 epan/crypt/dot11decrypt_util.h