Wireshark-commits: [Wireshark-commits] master 1e60efe: USB HID: refactor usage page identification
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Mar 2020 07:47:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e60efeb641c83a9436b0a5e258af56ee4ef413d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1e60efe by Filipe Laíns (lains@xxxxxxxxxxxxx):

    USB HID: refactor usage page identification
    
    The current approach to identify the the usage page and usage page usages
    is not great. It joins both the usage pages and the usages which are
    supposed to be individual values. The HID usage tables declarations also
    become harder to read as they hold the constructed value, not the value
    from the spec.
    
    This patch changes the HID usage table declartions from range_string to
    value_string, making them less bulky and easier to read, and splits out
    the usage page from the usages.
    
    Change-Id: I018406267fae43683d68c1349049e2c7c26f8ad6
    Signed-off-by: Filipe Laíns <lains@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36362
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ad6b194   t38: propagate ACDR changes in autogenerated file to the source
     add  1e60efe   USB HID: refactor usage page identification


Summary of changes:
 epan/dissectors/packet-usb-hid.c | 3956 +++++++++++++++++++-------------------
 1 file changed, 1978 insertions(+), 1978 deletions(-)