Wireshark-commits: [Wireshark-commits] master-3.2 9fdacd3: TLS: Limit the number of DNs in Certific
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 09 Mar 2020 22:09:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9fdacd3db60d15c9c17cae6a98ef8a7941cb8f94
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

9fdacd3 by Andre Luyer (andre@xxxxxxxx):

    TLS: Limit the number of DNs in Certificate Request messages
    
    When the Distinguished Names list is large in the Certificate Request it can
    trigger the "Dissector bug warning". Having a huge list in the tree pane is
    not useful anyway so this change limits the amount of DNs added to the tree,
    preventing this fault condition.
    It is indicated by adding a "[Tree view truncated]" item.
    
    A side effect is that a handshake is no longer incorrectly flagged as 'resumed'
    because the Server Hello Done in the same packet is now dissected.
    
    Bug: 16202
    Change-Id: Ib315940dcabc2d6b31cf3562354214158ea545a5
    Reviewed-on: https://code.wireshark.org/review/36314
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 914bb159f781c2f3a788fb68a3bacd3f54e24179)
    Reviewed-on: https://code.wireshark.org/review/36351
    Reviewed-by: André Luyer <andre@xxxxxxxx>
    

Actions performed:

    from  b2db596   Qt: Fix Copy Description from context menu
     add  9fdacd3   TLS: Limit the number of DNs in Certificate Request messages


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 15 ++++++++++++++-
 epan/dissectors/packet-tls-utils.h |  8 +++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)