Wireshark-commits: [Wireshark-commits] master 76c8c3e: afs: fix backup & butc RPC confusion
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 09 Mar 2020 06:30:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76c8c3ef0e7e722b7c713fad8caa2ddcf5da05f5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

76c8c3e by Mark Vitale (mvitale@xxxxxxxxxxxxxx):

    afs: fix backup & butc RPC confusion
    
    The AFS dissector was erroneously attempting to dissect the RPCs for the
    Backup Tape Controller (BUTC) on the BACKUP port 7021.  A different set
    of RPCs for the Backup Database Server are served on the backup port
    7021.
    
    To address this confusion:
    - Rename the existing "backup" RPC table to "butc", and dissect it on
    the correct port.  This port may be in a range from 7025 up to the
    maximum 65535.
    - Create a new "backup" RPC table with the correct RPC names for those
    exported on the 7021 port.
    - Make other adjustments as needed to properly distinguish and handle
    both "backup" and "butc" requests and replies.
    
    With these changes, the BKUP operations in the Wireshark afs.cap sample
    capture are now dissected correctly.
    
    Change-Id: I906787889e10cad307d9a6fa610c3e35f2b69184
    Reviewed-on: https://code.wireshark.org/review/36300
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  78b08dd   afs: make defragment / reassembly configurable
     add  76c8c3e   afs: fix backup & butc RPC confusion


Summary of changes:
 epan/dissectors/packet-afs.c | 87 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 84 insertions(+), 3 deletions(-)