Wireshark-commits: [Wireshark-commits] master-3.2 0cccc61: afs: correctly calulate padding for stri
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 06 Mar 2020 15:47:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cccc61a49d37c2e14fb587030205686bc66562d
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

0cccc61 by Mark Vitale (mvitale@xxxxxxxxxxxxxx):

    afs: correctly calulate padding for strings
    
    length+value strings in AFS are padded to a multiple of 4 octets.
    A bug caused the dissector to add an extra 4-octet pad when no padding
    was required.  This causes any field after the string to be
    mis-dissected, resulting in a false alarm "Malformed packet".
    
    Correct the padding logic to eliminate the false alarm.
    
    Change-Id: I2edc58f20830c2df99d87cdd7d0cbf3bc9b92991
    Reviewed-on: https://code.wireshark.org/review/36297
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    (cherry picked from commit 77d2bf81a75f682cf09f07ac02b2f4cb92324a59)
    Reviewed-on: https://code.wireshark.org/review/36315
    

Actions performed:

    from  acbbbde   gitlab-ci: remove unnecessary jobs, upgrade versions
     add  0cccc61   afs: correctly calulate padding for strings


Summary of changes:
 epan/dissectors/packet-afs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)