Wireshark-commits: [Wireshark-commits] master 4a2cd15: Qt: Fill in our item delegate editor backgro
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 03 Mar 2020 06:19:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a2cd15aa5c4cdd64aa24dcbdbc8b3d2d234c3f4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4a2cd15 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fill in our item delegate editor backgrounds.
    
    As the documentation for QAbstractItemDelegate::createEditor says,
    
    "The view's background will shine through unless the editor paints its
    own background (e.g., with setAutoFillBackground())."
    
    Set setAutoFillBackground(true) for a bunch of our editors where the
    underlying widget's background was showing.
    
    Change-Id: I77e96548e99c74a73c89f8037c1f894a6a5584f1
    Reviewed-on: https://code.wireshark.org/review/36260
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fb28b60   QUIC: Fix frame type (it is also a varint)
     add  4a2cd15   Qt: Fill in our item delegate editor backgrounds.


Summary of changes:
 ui/qt/capture_options_dialog.cpp    |  1 +
 ui/qt/extcap_argument.cpp           |  1 +
 ui/qt/models/column_list_model.cpp  | 33 ++++++++++--------
 ui/qt/models/decode_as_delegate.cpp | 67 ++++++++++++++++++++-----------------
 ui/qt/models/pref_delegate.cpp      |  9 +++--
 5 files changed, 64 insertions(+), 47 deletions(-)