Wireshark-commits: [Wireshark-commits] master-3.2 c1c8998: macOS: Software update fixes.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Feb 2020 16:31:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1c8998b83124e852f8cd9ac3369e992e4e9256e
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

c1c8998 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    macOS: Software update fixes.
    
    Run our software update checks in the foreground.
    
    Post NSApplicationWillTerminateNotification prior to exiting the
    application. This *should* start the automatic updater if a new version
    of Wireshark was downloaded in the background, but is difficult to test
    without a fully signed and notarized application bundle.
    
    Bug: 16416
    Change-Id: I212dbb42e1cafff713ff195b448c2799750bc6ac
    Reviewed-on: https://code.wireshark.org/review/36221
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit b3871fb864966695d1e63bd201f9781f9b147485)
    Reviewed-on: https://code.wireshark.org/review/36230
    

Actions performed:

    from  7847721   Qt: fix packet list selection regression
     add  c1c8998   macOS: Software update fixes.


Summary of changes:
 docbook/release-notes.adoc |  6 +++---
 ui/macosx/sparkle_bridge.h |  2 ++
 ui/macosx/sparkle_bridge.m | 16 +++++++++++++++-
 ui/software_update.c       |  1 +
 4 files changed, 21 insertions(+), 4 deletions(-)