Wireshark-commits: [Wireshark-commits] master 27dc3d1: btatt: Call btatt.handle subdissectors
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=27dc3d14818dde694b4b3b802301bf9b7c23fe2e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
27dc3d1 by Angelos Drossos (wireshark.develangel@xxxxxxxxxxxxxxx):
btatt: Call btatt.handle subdissectors
The BT ATT protocol dissector has a dissector table for the
`btatt.handle` field so that is is possible to register subdissectors.
But registrating the subdissector via `btatt.handle` field has no
effect. Instead, it has to be registered via `bluetooth.uuid` field.
In some cases, the BT ATT dissector doesn't call its subdissectors when
it is registered via `bluetooth.uuid` field: It is when no frame
connects the BT UUID to the handle.
This fix now calls the registered subdissector of the `btatt.handle`
field if any.
As an improvement, duplicate code could be removed for BT GATT
subdissectors because dissect_btgatt() extracts already the UUID from
the short name and then calls dissect_attribute_value().
The BT GATT subdissectors will be shown as subtree as before because its
implementation is in the same file. All other subdissectors will get its
own root tree as it is common for new protocol layers.
Bug: 16371
Change-Id: I99393e51e949a6488014f175c09a44743ce353a2
Reviewed-on: https://code.wireshark.org/review/36176
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d398471 Add support for ISO 15765-2:2015 jumbo frames
add 27dc3d1 btatt: Call btatt.handle subdissectors
Summary of changes:
epan/dissectors/packet-btatt.c | 31 ++++++++++++-------------------
1 file changed, 12 insertions(+), 19 deletions(-)
