Wireshark-commits: [Wireshark-commits] master cd6134d: Add ws_strtoi() and ws_strtoui() routines an
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2020 08:28:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd6134da9086bf66513a8fa842a4aa04e690025f
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cd6134d by Guy Harris (guy@xxxxxxxxxxxx):

    Add ws_strtoi() and ws_strtoui() routines and use them.
    
    Those fetch gint and guint values, respectively, rather than values with
    specified sizes in bits.
    
    This should squelch Coverity CID 1457357.
    
    Change-Id: Ia8f100bd3fe90c266e24a4346f80b2667c653b93
    Reviewed-on: https://code.wireshark.org/review/36177
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f2a64e9   RTP: Add support for RTP over TCP (RFC 4571)
     add  cd6134d   Add ws_strtoi() and ws_strtoui() routines and use them.


Summary of changes:
 debian/libwsutil0.symbols |  4 +++
 ui/capture_ui_utils.c     | 34 ++++++++-----------
 wsutil/strtoi.c           | 84 +++++++++++++++++++++++++++++++++++++++++++++++
 wsutil/strtoi.h           |  4 +++
 4 files changed, 105 insertions(+), 21 deletions(-)