Wireshark · Wireshark-commits: [Wireshark-commits] master 0875845: f5ethtrailer: Continued clean-up from plug-in import

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0875845e90d7ac9e7e905be09668d7a38410229a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0875845 by Jason Cohen (j.cohen@xxxxxx):

    f5ethtrailer: Continued clean-up from plug-in import
    
    This dissector was iniitally a plug-in and was converted to a built-in
    on Change: https://code.wireshark.org/review/#/c/26428/
    There is still a fair bit of clean up necessary.  I'm attempting some of
    that here.  Detailed below are steps of each of the consecutive patch
    sets as I work through it.  They are in a top (oldest) down (newest)
    order.  If there is another way I should do this please let me know.
    
    f5ethtrailer: Fix indiscriminate consumption of trailers
    
    Dissector was not discriminating in consuming trailers.  Rewrote
    the heuristic to look for specific signatures and return if they
    are not found. Setting heuristic back to enabled since it now only
    consumes trailers that it should be able to dissect.
    
    f5ehtrailer: remove unneeded () from around return values
    
    f5ethtrailer: Remove macros
    
    Macros were left over from using the same same code base to compile the
    plugin against differed API versions (versions of Wireshark).  Now that
    the code is part of the core repository, it only needs to apply to the
    branch it exists in.
    
    f5ethtrailer: Correct FILEINFO mappings
    
    f5ethtrailer: Eliminate compile time option to exclude POP_OTHER_FIELDS
    
    This is now a runtime pref that is disabled by defualt.
    
    Remove unnecessary NULL check
    
    f5ethtrailer: Comment clean up
    
    Clean up a few comments, make sure every function has a doc comment
    
    f5ethtrailer: Trailer detection improved
    
    Skip over leading zeros
    Add prefrence to walk remaining data looking for trailer.
    Disabled (default) Only look for trailers at first non-zero byte
    Enabled start at first non-zero byte looking for trailers.  Walk the
    remaining data byte-by-byte looking for a matching trailer.
    
    Change-Id: I6499ed6c6a760b668efe86632011cd07a7e447b2
    Reviewed-on: https://code.wireshark.org/review/36012
    Reviewed-by: Jason Cohen <kryojenik2@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8bda864   EAP: Remove a couple of string length assumptions.
     add  0875845   f5ethtrailer: Continued clean-up from plug-in import


Summary of changes:
 epan/dissectors/packet-f5ethtrailer.c | 1587 ++++++++++++++++++---------------
 1 file changed, 864 insertions(+), 723 deletions(-)