Wireshark · Wireshark-commits: [Wireshark-commits] master 18a7e64: get_dns_name: fixup some missing change introduced with c397adda

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18a7e64c85d80a479e289c01fa33740ac03e1d58
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

18a7e64 by Jeremiejig (me@xxxxxxxxxxxxx):

    get_dns_name: fixup some missing change introduced with c397adda8a7
    
    Following commit c397adda8a7 there was some missing change
    
    * Some `cur_offset += name_len` instead of `cur_offset += used_bytes`
    * Some missing format_text
    
    I took a look at the code after observing a bug with RRSIG record.
    The signature in RRSIG was dissecting with some strange offset.
    
    You can easily generate some pcap with those commands
    
    delv @1.1.1.1 A www.cloudflare.com
    and/or
    dig @1.1.1.1 +dnssec www.cloudflare.com
    
    Change-Id: Ibd6a6248b7497b8409d7797dc320035c8c2d1ed8
    Reviewed-on: https://code.wireshark.org/review/36080
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c129c28   Qt: Allow creating new files in extcap fileselect
     add  18a7e64   get_dns_name: fixup some missing change introduced with c397adda8a7


Summary of changes:
 epan/dissectors/packet-dhcp.c   | 12 ++++++++----
 epan/dissectors/packet-dns.c    | 15 ++++++++-------
 epan/dissectors/packet-icmpv6.c |  2 +-
 epan/dissectors/packet-lwres.c  |  8 +++++---
 4 files changed, 22 insertions(+), 15 deletions(-)