Wireshark-commits: [Wireshark-commits] master-3.2 26d9a5e: QUIC: recognize Connection ID between 1
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Feb 2020 09:03:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26d9a5e9fcb32a1e8d1f19f75907489149c82968
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

26d9a5e by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: recognize Connection ID between 1 and 3 bytes
    
    Since draft 22 the CID length ranges from 1 - 20 instead of 4 * 18.
    Firefox 74.0a1 happened to send a SCID of 3 bytes which resulted in
    failure to find the connection for short header packets.
    
    Ping-Bug: 13881
    Change-Id: Iacff6ea215fd27861d196bc831991be7e4450419
    Reviewed-on: https://code.wireshark.org/review/35993
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 9e894cfbd8a9252c3bcc34abf36ff200b70b4262)
    Reviewed-on: https://code.wireshark.org/review/36102
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c27c54e   QUIC: Need to remove Retry Integry Tag to Retry Token Length
     add  26d9a5e   QUIC: recognize Connection ID between 1 and 3 bytes


Summary of changes:
 epan/dissectors/packet-quic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)