Wireshark-commits: [Wireshark-commits] master 937c7c5: Debian+RPM: Require QtSVG.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Feb 2020 01:43:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=937c7c512ab5bcb4d70e48760a11af825742effa
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

937c7c5 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Debian+RPM: Require QtSVG.
    
    Although we don't depend on any of Qt's SVG classes directly, we do use
    SVG icons in Preferences → Appearance → Language and QIcon loads its SVG
    engine dynamically. If it's not present Wireshark will still run, but
    the user won't see any flag icons.
    
    Require QtSVG in the Debian and RPM packaging. It's not that large (~
    400k here on Ubuntu 18.04) and ensures that we have a uniform user
    experience across platforms. In this particular case, if the user
    experience happens to be "Wireshark's UI is in a language I don't
    understand" the little flags can come in handy.
    
    Change-Id: If3c2e8a6040967353dbc462ee475ef12514b25f9
    Reviewed-on: https://code.wireshark.org/review/36037
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  7646295   SDP: clarify that the G722 sample rate is actually 16000
     add  937c7c5   Debian+RPM: Require QtSVG.


Summary of changes:
 debian/control                  | 5 +++--
 packaging/rpm/wireshark.spec.in | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)