Wireshark-commits: [Wireshark-commits] master 19b3376: LDAP bogus malformed errors: decoding encryp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Feb 2020 06:28:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19b3376a24192319a008399e8c44f1655f6dcebd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

19b3376 by Cal Turney (cturney111@xxxxxxxxx):

    LDAP bogus malformed errors: decoding encrypted data
    
    In captures of LDAP Privacy (encrypted) data, the dissector
    threw Malformed errors because had it attempted to decode
    encrypted payloads. See attached example capture
    "PRIVACY-payload-(encrypted-data).pcap" at
    https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16358
    
    Bug: 16358
    Change-Id: Ic6d74d464157b145896090316ba73af025af7312
    Reviewed-on: https://code.wireshark.org/review/36038
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  80e1c54   CANopen: Add SDO Block Upload/Download decoding
     add  19b3376   LDAP bogus malformed errors: decoding encrypted data


Summary of changes:
 epan/dissectors/asn1/ldap/packet-ldap-template.c |  99 +++++++++++----------
 epan/dissectors/asn1/ldap/packet-ldap-template.h |  10 +--
 epan/dissectors/packet-ldap.c                    | 105 +++++++++++------------
 epan/dissectors/packet-ldap.h                    |  10 +--
 4 files changed, 111 insertions(+), 113 deletions(-)