Wireshark-commits: [Wireshark-commits] master 2580053: TFTP: Rewritten object (file) export algorit
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 05 Feb 2020 10:24:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=25800536388aa2b567a18874dd0312a2bb29464d
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2580053 by Roman-Koshelev (roman.koshelev@xxxxx):

    TFTP: Rewritten object (file) export algorithm
    
    Significantly increased readability of the code, speed of work
    and reduced size of the consumed memory.
     - The number of memory allocations has been reduced from N to a few
     - Removed double (redundant) data copying
    
    Change-Id: I05aed194932ed3305eefb6e2e0f847e57851c41c
    Reviewed-on: https://code.wireshark.org/review/36026
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  55f8332   Qt: simplify decode_as_ action in the packet details view
     add  2580053   TFTP: Rewritten object (file) export algorithm


Summary of changes:
 epan/dissectors/packet-tftp.c | 165 ++++++++++++------------------------------
 1 file changed, 47 insertions(+), 118 deletions(-)