Wireshark-commits: [Wireshark-commits] master-3.2 fd0e8bc: Qt: simplify decode_as_ action in the pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 05 Feb 2020 04:35:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd0e8bca3bbf4e8e4f843b66e778f65459e381c6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

fd0e8bc by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: simplify decode_as_ action in the packet details view
    
    Use the "create_new" property convention similar to PacketList. Fix a
    "QWidget::insertAction: Attempt to insert null action" warning in the
    packet dialog while at it.
    
    Change-Id: I29b3b113aba92634b1b9a3427e2313fca30633eb
    Reviewed-on: https://code.wireshark.org/review/36023
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 55f83324ef48f79f7e0471a26213b9c901d089ad)
    Reviewed-on: https://code.wireshark.org/review/36034
    

Actions performed:

    from  83c66f5   Qt: make Decode As from packet list functional again
     add  fd0e8bc   Qt: simplify decode_as_ action in the packet details view


Summary of changes:
 ui/qt/main_window_slots.cpp |  5 +----
 ui/qt/proto_tree.cpp        | 12 ++++--------
 ui/qt/proto_tree.h          |  1 -
 3 files changed, 5 insertions(+), 13 deletions(-)