Wireshark · Wireshark-commits: [Wireshark-commits] master 0596047: Qt: fix missing IP hosts in Resolved Addresses dialog

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0596047e3fde7ebcd09f5daa4782e423795783c1
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0596047 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix missing IP hosts in Resolved Addresses dialog
    
    Fix several issues in the Resolved Addresses dialog:
     - Missing IP hosts because the list was populated with one
       tab-separated item while the caller expected space-separated items.
     - Fix duplicate entries due to the "values" list not being cleared.
     - Remove IPv4/IPv6 Hash Tables since these are a superset of IPv4/IPv6
       Hosts, except that the former also includes mappings without a known
       name (e.g. 8.8.8.8 -> 8.8.8.8).
     - Fold both IPv4 and IPv6 hosts into one as before. Users like me
       usually look for any IP match, regardless of the address family.
     - Minor optimizations: do not construct the label every time.
     - Rename "Mac Address" [sic] to simply "Address", that covers both IP
       addresses and MAC addresses.
    
    Bug: 16366
    Change-Id: I6253fc01da7b6429ce093e7db9fe58e235b7c137
    Fixes: v3.1.1rc0-244-g743f8598cd0b ("Qt: Rework Resolved Addresses dialog")
    Reviewed-on: https://code.wireshark.org/review/36022
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fcc9046   ieee80211: More correctly handle EOSP vs bit-4 in QoS frames.
     add  0596047   Qt: fix missing IP hosts in Resolved Addresses dialog


Summary of changes:
 ui/qt/models/resolved_addresses_models.cpp | 105 +++++++----------------------
 1 file changed, 26 insertions(+), 79 deletions(-)