Wireshark-commits: [Wireshark-commits] master 37e74c9: TFTP: Transferred files may now be reassembl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 03 Feb 2020 14:42:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37e74c9ceb2abc971639c3f58c7cd66d953b1939
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

37e74c9 by Roman Koshelev (roman.koshelev@xxxxx):

    TFTP: Transferred files may now be reassembled and dissected.
    
    This allows higher-layer file or protocol dissectors to dissect the file
    contents. Note that there are currently no dissectors that do this in-tree,
    but an example of how to do this is at:
         https://github.com/Roman-Koshelev/Arinc-615a-Wireshark-Dissector.
    
    Bug: 16069
    Change-Id: I88236175128efd0f6d474218dd117f5b0ca1fae9
    Reviewed-on: https://code.wireshark.org/review/35553
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  d597655   RLC-NR: make dissector handle volatile to avoid compiler error (gcc 4.8.5)
     add  37e74c9   TFTP: Transferred files may now be reassembled and dissected.


Summary of changes:
 epan/dissectors/packet-tftp.c | 201 ++++++++++++++++++++++++++++++++++++------
 epan/dissectors/packet-tftp.h |  18 ++++
 2 files changed, 194 insertions(+), 25 deletions(-)
 create mode 100644 epan/dissectors/packet-tftp.h