Wireshark-commits: [Wireshark-commits] master-3.2 908ed20: artnet: Fix ArtPollReply universe calcul
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jan 2020 13:57:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=908ed20a9ccbf9561188d41be3603b2f10fc9b91
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

908ed20 by Erwin Rol (erwin@xxxxxxxxxxxx):

    artnet: Fix ArtPollReply universe calculation
    
    The SubSwitch field holds bit 7-4 of the 15bit port address, but
    it holds it in bit 3-0 so we have to shift it 4 bits instead of
    taking bit 7-4 of the SubSwitch field.
    
    Change-Id: I7841d64749e8a561e4ee928a23a3c46cb5be34cb
    Signed-off-by: Erwin Rol <erwin@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/35910
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 824fef51aa3efc7a146ea57de90b1a6135614496)
    Reviewed-on: https://code.wireshark.org/review/35946
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  05939eb   rdm: Remove incorrect dissection of ack overflow data
     add  908ed20   artnet: Fix ArtPollReply universe calculation


Summary of changes:
 epan/dissectors/packet-artnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)