Wireshark-commits: [Wireshark-commits] master 8881371: voip_calls_dialog/voip_calls: Fix for duplic
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 07 Jan 2020 04:46:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=888137161cd1e4fe48c56cd6681cae5c10deede2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8881371 by Jirka Novak (j.novak@xxxxxxxxxxxx):

    voip_calls_dialog/voip_calls: Fix for duplicated entries after retap
    
    Issue seen from 2.6:
    1) Open pcap with any VoIP call
    2) Open Telephony->VoIP calls
    3) Select one or more calls
    4) Press Flow Sequence - sequence is shown
    5) Close Flow Sequence
    6) Press Play Streams - Play dialog is shown
    7) Close Play dialog
    8) Press Flow Sequence - sequence is shown, but all entries are duplicated
    
    If you repeat 6-7 multiple times, all entries are shown multiple times in 8
    
    Patch adds missing clear of graph_analysis before retaping the stream.
    Tested on master, but should be backported to as many stable branches as possible.
    
    Change-Id: I9793f6e874defde2f377732d78689e957df71b33
    Reviewed-on: https://code.wireshark.org/review/35672
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2060e02   Qt: don't use monospace fonts for licence dialog.
     add  8881371   voip_calls_dialog/voip_calls: Fix for duplicated entries after retap


Summary of changes:
 ui/voip_calls.c | 4 ++++
 1 file changed, 4 insertions(+)