Wireshark · Wireshark-commits: [Wireshark-commits] master-3.2 7baba81: IPv4: Fix incorrect expert info for IGMP TTL

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7baba81f0193de647c4c409d4c7e3a9b86a114de
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

7baba81 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    IPv4: Fix incorrect expert info for IGMP TTL
    
    IGMP uses TTL = 1 for the network control block. The code assumes
    a certain registered multicast destination address always carries
    traffic for that protocol, which isn't true. For example mDNS
    usually uses a TTL of 255 but IGMP Membership reports use a TTL
    of 1 for the same destination address.
    
    The end result is that IGMP traffic to mDNS multicast destination
    shows a confusing and incorrect "TTL != 255 for the Local Network
    Control Block" expert info.
    
    Rename the "ttl" variable for clarity.
    
    Change-Id: I693306cd6531aa250a6f5884a6731a2ea254bf2a
    Reviewed-on: https://code.wireshark.org/review/35639
    Reviewed-by: João Valverde <j@xxxxxx>
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 376d8770121ab848ee4b679f2aa18bea13e42742)
    Reviewed-on: https://code.wireshark.org/review/35659
    

Actions performed:

    from  4522019   [Automatic update for 2020-01-05]
     add  7baba81   IPv4: Fix incorrect expert info for IGMP TTL


Summary of changes:
 epan/dissectors/packet-ip.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)