Wireshark-commits: [Wireshark-commits] master 76dfe60: packet-iec104: Use pinfo->match_uint instead
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 03 Jan 2020 13:12:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76dfe6004b7cc7e0c90b962a74cdc180bb0b4c7f
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

76dfe60 by Jiří Engelthaler (EngyCZ@xxxxxxxxx):

    packet-iec104: Use pinfo->match_uint instead of port number from configuration
    
    Dissector port number is used to determine the direction.
    It will not work with Decode As when port number from the configuration
    is used. It is better to use the actual dissector port from pinfo->match_uint.
    
    Change-Id: I156728a66ed0cf0fe536da8d9ae958c8c4e0b361
    Reviewed-on: https://code.wireshark.org/review/35632
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d832145   Qt: Add Spanish (es) translation assets.
     add  76dfe60   packet-iec104: Use pinfo->match_uint instead of port number from configuration


Summary of changes:
 epan/dissectors/packet-iec104.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)