Wireshark-commits: [Wireshark-commits] master-3.2 867f435: BGP: Correct Tunnel Encapsulation Attrib
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 02 Jan 2020 05:54:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=867f435d9595e996365e89122b00dc957c1ce841
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

867f435 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    BGP: Correct Tunnel Encapsulation Attribute Sub-TLV length handling
    
    When Sub-TLV type >= 128 then the length field is 2 octets.
    Get the correct Sub-TLV length and adjust offsets.
    
    This is a simplified version of change 35587 which does this and adds
    enhancements for dissection of the various Sub-TLVs.
    
    Bug: 16294
    Change-Id: I34f3b2d10159652c1b2f664b74831baadc616e27
    Reviewed-on: https://code.wireshark.org/review/35609
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  df01c3b   Happy New Year 2020
     add  867f435   BGP: Correct Tunnel Encapsulation Attribute Sub-TLV length handling


Summary of changes:
 epan/dissectors/packet-bgp.c | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)