Wireshark · Wireshark-commits: [Wireshark-commits] master 623b347: Protobuf: add dissecting protobuf fields as wireshark fields pre

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=623b347d1e863f7cd2d331926106321d3182d169
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

623b347 by Huang Qiangxiong (qiangxiong.huang@xxxxxx):

    Protobuf: add dissecting protobuf fields as wireshark fields preferences, etc.
    
    Two enhancements and one fixed bug:
    
    1. Add dissecting protobuf fields as wireshark (header) fields preferences. User
    can input the full names of protobuf fields or messages in Filter toolbar for
    searching.
    
    2. Add 'protobuf_field' dissector table. Dissector based on protobuf can register
    itself to 'protobuf_field' keyed with the full names of fields of BYETS or STRING
    types.
    
    3. A bug about search MESSAGE or ENUM type in context is fixed.
    
    4. Another small enhancement is adding prefs_set_preference_effect_fields() which
    can mark a preference that affects fields change (triggering FieldsChanged event).
    
    See the linked bug for sample capture file and .proto files.
    
    Ping-Bug: 16209
    Change-Id: Ibc3c45a6d596a8bb983b0d847dd6a22801af7e04
    Reviewed-on: https://code.wireshark.org/review/35111
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5d342b0   Windows: upgrade Npcap to 0.9986
     add  623b347   Protobuf: add dissecting protobuf fields as wireshark fields preferences, etc.


Summary of changes:
 debian/libwireshark0.symbols        |   1 +
 docbook/release-notes.adoc          |   4 +
 epan/dissectors/packet-protobuf.c   | 341 +++++++++++++++++++++++++++++++++++-
 epan/prefs-int.h                    |   1 +
 epan/prefs.c                        |   9 +
 epan/prefs.h                        |   8 +
 epan/protobuf-helper.c              |  27 ++-
 epan/protobuf-helper.h              |  16 ++
 epan/protobuf_lang_tree.c           | 115 +++++++++---
 epan/protobuf_lang_tree.h           |  17 ++
 ui/qt/preference_editor_frame.cpp   |   5 +
 ui/qt/preferences_dialog.cpp        |   4 +
 ui/qt/protocol_preferences_menu.cpp |   7 +
 13 files changed, 518 insertions(+), 37 deletions(-)
 mode change 100644 => 100755 docbook/release-notes.adoc