Wireshark-commits: [Wireshark-commits] master dc19356: Win32: Fixup our file dialog titles.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2019 01:04:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc19356be2bc30f6abf8aa0dee1ef630224dd35b
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dc19356 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Win32: Fixup our file dialog titles.
    
    Add a "title" argument to each of the Win32 file dialog routines, and
    pass in one constructed using wsApp->windowTitleString.
    
    Change-Id: I5ff862bd28cd16093d99ae1559ecbaca907350da
    Reviewed-on: https://code.wireshark.org/review/35383
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d884ff2   Qt: fix wrong checks.
     add  dc19356   Win32: Fixup our file dialog titles.


Summary of changes:
 ui/qt/capture_file_dialog.cpp      | 13 +++++++++----
 ui/qt/export_dissection_dialog.cpp |  4 ++--
 ui/win32/file_dlg_win32.c          | 21 +++++++++++----------
 ui/win32/file_dlg_win32.h          |  9 +++++----
 4 files changed, 27 insertions(+), 20 deletions(-)