Wireshark-commits: [Wireshark-commits] master 7be2d96: Qt: We show preference panes using their mod
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7be2d964f04d8158782719ed41f3342c7f1c126d
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
7be2d96 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: We show preference panes using their module names.
PreferencesDialog::setPane takes a preference module name. Fix a
comparison in PrefModuleTreeView::setPane and update some variable names
in order to make things a bit more obvious.
Modernize some related code while we're here.
Bug: 16250
Change-Id: I8f4c7e5261a219e3f32e6e9a71574d81b1852219
Reviewed-on: https://code.wireshark.org/review/35304
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from f2c2b96 README.dissector: Add a note about integer promotion.
add 7be2d96 Qt: We show preference panes using their module names.
Summary of changes:
ui/qt/address_editor_frame.cpp | 3 +--
ui/qt/main_window.cpp | 20 ++++++++++----------
ui/qt/main_window.h | 2 +-
ui/qt/main_window_slots.cpp | 4 ++--
ui/qt/preference_editor_frame.cpp | 3 +--
ui/qt/preferences_dialog.cpp | 4 ++--
ui/qt/preferences_dialog.h | 7 ++++++-
ui/qt/widgets/pref_module_view.cpp | 24 ++++++++++++------------
ui/qt/widgets/pref_module_view.h | 4 ++--
ui/qt/wireless_frame.cpp | 2 +-
10 files changed, 38 insertions(+), 35 deletions(-)