Wireshark · Wireshark-commits: [Wireshark-commits] master 082ad65: ieee80211: Improve EAPOL Key MIC Len handling in some cases.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=082ad65a0d738195e9b113f19abe75a16588a822
Submitter: "Richard Sharpe <realrichardsharpe@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

082ad65 by Richard Sharpe (realrichardsharpe@xxxxxxxxx):

    ieee80211: Improve EAPOL Key MIC Len handling in some cases.
    
    If the capture does not contain any indication of the Key MIC Len or we
    are making only one pass (such as with tshark) we can actually figure
    out the Key MIC Len if we see the first frame of the four-way handshake.
    
    We only use this approach if we used the default value for the Key MIC Len
    and defer to other information if it is available. We also save the value
    once we have figured it out and only try to figure it out on the first
    frame of the four-way handshake.
    
    If we cannot determine the Key MIC length from the first frame in the
    four-way handshake we can use the second frame in the four-way handshake.
    However, we also need to keep some extra state, specifically, whether or not
    we have actually set the last AKM suite seen.
    
    Bug: 16210
    Change-Id: I28bc7dacbd34d03b24e66371f66b22853fa608d1
    Reviewed-on: https://code.wireshark.org/review/35119
    Petri-Dish: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Mikael Kanstrup <mikael.kanstrup@xxxxxxxx>
    Reviewed-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    

Actions performed:

    from  3e97b28   RTCP: Add expert info.
     add  082ad65   ieee80211: Improve EAPOL Key MIC Len handling in some cases.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 200 +++++++++++++++++++++++++++++++++----
 epan/dissectors/packet-ieee80211.h |   3 +
 2 files changed, 185 insertions(+), 18 deletions(-)