Wireshark-commits: [Wireshark-commits] master-3.0 dd9946f: ws_pipe: fix memory leaks in spawn argum
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd9946f1418702cb2900e4251377fa12e414ddb5
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
dd9946f by Peter Wu (peter@xxxxxxxxxxxxx):
ws_pipe: fix memory leaks in spawn arguments handling
On Windows, ws_pipe_spawn_sync always leaks 'winargs', and leaks 'argv'
on some error paths. Fix these and refactor the common argument parsing
functionality to reduce duplication of functionality.
Change-Id: I8fa5ca45aec20b53f6fa243b0dd07241a345f7ab
Reviewed-on: https://code.wireshark.org/review/32932
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
(cherry picked from commit dd1245f5be20e10f8ef917b20c302129b505cd97)
Reviewed-on: https://code.wireshark.org/review/35291
Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Actions performed:
from 6c686c7 wsutil: Fix 30 seconds freeze if process fails to start
add dd9946f ws_pipe: fix memory leaks in spawn arguments handling
Summary of changes:
wsutil/ws_pipe.c | 182 ++++++++++++++++++++++++++++++-------------------------
wsutil/ws_pipe.h | 1 +
2 files changed, 102 insertions(+), 81 deletions(-)