Wireshark-commits: [Wireshark-commits] master-3.2 79863cf: TLS: support Facebook's TLS 1.3 draft 23
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Nov 2019 15:23:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79863cfb290f0fa529236ba99c32934e6f0d67a5
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

79863cf by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: support Facebook's TLS 1.3 draft 23 and 26 versions
    
    Verified with fizz-tls13-draft-23-26-rfc8446-dsb.pcapng from the bug.
    Decryption of early data, handshake and application data for almost all
    versions (draft 23, draft 26, RFC 8446) is working. Only early data
    decryption for draft 23 fails because the draft version is not yet set
    during trial decryption before the Server Hello is received. That is
    such a rare case however, do not bother fixing that.
    
    Bug: 16175
    Change-Id: Ie9046bf3f04c40b9c8fa2128f06844d2e7bd3e6d
    Reviewed-on: https://code.wireshark.org/review/35245
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 7c3ae2b5ab0b9f4c683c3dc8b520ed3c0cd99726)
    Reviewed-on: https://code.wireshark.org/review/35252
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4d00e63   WireGuard: fix MAC1 computation for non-zero reserved case
     add  79863cf   TLS: support Facebook's TLS 1.3 draft 23 and 26 versions


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)