Wireshark-commits: [Wireshark-commits] master-3.2 11aea38: Qt: fix crash on Next/Previous Packet in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Nov 2019 12:12:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11aea382c4f238d4e963efeaffcaeb42974f5d4e
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

11aea38 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix crash on Next/Previous Packet in Conversation without selection
    
    Protect against a NULL edt pointer. That can occur when the packet
    details view is empty, e.g. when no packet is selected.
    
    Bug: 16228
    Change-Id: Ie9621db4b84b504e4d9cee2add5004df2e383970
    Reviewed-on: https://code.wireshark.org/review/35204
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit c9bb676118caade49e2f9365910a76cbc0a5f343)
    Reviewed-on: https://code.wireshark.org/review/35209
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  daa79b6   ISAKMP: fix dissection of SA TEK payload for non IP address
     add  11aea38   Qt: fix crash on Next/Previous Packet in Conversation without selection


Summary of changes:
 ui/qt/main_window_slots.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)