Wireshark-commits: [Wireshark-commits] master-3.0 9eb6e05: rtp_analysis_dialog: save as au: fix for
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Nov 2019 15:12:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9eb6e05d98df52acac3ee13f65192f5cdc51a2a9
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

9eb6e05 by Jirka Novak (j.novak@xxxxxxxxxxxx):

    rtp_analysis_dialog: save as au: fix for streams with multiple codecs
    
    When the stream contains a mix of G.711A/U and silence, the RTP Analysis dialog
     prevented it from being saved. Add an exception for silence to fix this.
    
    Change-Id: I46bb1392244ff0ba300c371fb5ccd110fbd59a7e
    Reviewed-on: https://code.wireshark.org/review/34901
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 0f35832fce91d4202f788939056d47d6abf2feb3)
    Reviewed-on: https://code.wireshark.org/review/34968
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  c500ad4   TLS: report encrypted TLS alerts as such
     add  9eb6e05   rtp_analysis_dialog: save as au: fix for streams with multiple codecs


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp | 27 +++++++++++++++++++++++----
 ui/tap-rtp-common.c           |  5 +++++
 ui/tap-rtp-common.h           |  7 +++++++
 3 files changed, 35 insertions(+), 4 deletions(-)