Wireshark-commits: [Wireshark-commits] master c39bb02: Qt: Fix memory leaks in FilterListModel::rel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Nov 2019 09:30:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c39bb02fbc1ccc5533df3b1d932e50c5d0fda739
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c39bb02 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix memory leaks in FilterListModel::reload()
    
    This fixes up to 6 string leaks in FilterListModel::reload().
    
    1. The char pointer returned from get_persconffile_path() and
       get_datafile_path() is allocated and must be free'd by the caller.
    
    2. QFile.setFileName() takes a QString() so don't strdup() the name
       given because that will leak as well.
    
    Change-Id: I580020a5ff37a9b2b8ae16179ac6d7ba4a0f16da
    Reviewed-on: https://code.wireshark.org/review/34964
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  22ab2b9   nvme: Dissect NVMe Identify Ctrl (CNS 0x1) data response
     add  c39bb02   Qt: Fix memory leaks in FilterListModel::reload()


Summary of changes:
 ui/qt/models/filter_list_model.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)