Wireshark-commits: [Wireshark-commits] master 0b0bbb8: HTTP2/gRPC: Support streaming mode reassembl
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b0bbb8060749c1d400a20effd53decfa3a258a9
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
0b0bbb8 by Huang Qiangxiong (qiangxiong.huang@xxxxxx):
HTTP2/gRPC: Support streaming mode reassembly
If working in streaming RPC mode, many grpc messages will be
contained in one http2 stream, the stream will end very late
(for example ETCD watch stream).
So we could not rely on old http2 reassembly mode which call
sub-dissector only END_STREAM appeared. We need a reassembly
mode that call subdissector which support streaming mode as
soon as the message in STREAM is available.
Please refer to comments of
reassemble_http2_data_according_to_subdissector() function
of epan/dissectors/packet-http2.c for more detail.
See the linked bug for streaming mode gRPC capture files.
Ping-Bug: 16160
Change-Id: Id9e5337a0e3ca9f8c8119d74d2c1fe4cc263afc3
Reviewed-on: https://code.wireshark.org/review/23988
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from accd563 Qt: Consolidate mimedata usage
add 0b0bbb8 HTTP2/gRPC: Support streaming mode reassembly
Summary of changes:
AUTHORS.src | 6 +
docbook/release-notes.adoc | 2 +
epan/dissectors/packet-grpc.c | 90 ++++++--
epan/dissectors/packet-http2.c | 455 +++++++++++++++++++++++++++++++++++++++--
4 files changed, 523 insertions(+), 30 deletions(-)