Wireshark-commits: [Wireshark-commits] master 5517459: wslua: Fix memleak of unregistered ProtoFiel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Oct 2019 15:06:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=551745998ef4a9352bca2a0035780bc1a96e55eb
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5517459 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    wslua: Fix memleak of unregistered ProtoField strings
    
    If a ProtoField object was created, but not linked to a Proto, then the
    strings field and all elements (depending on type) would leak.
    
    This is a follow-up to g79fef2ae and fixes the real issue in g44870fb1.
    
    Change-Id: I01880a92bb20fae45f68c754b07daeb07630deec
    Reviewed-on: https://code.wireshark.org/review/34872
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Vasil Velichkov <vvvelichkov@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  5fb8970   NAS 5GS: fix dissection of ngKSI in Registration Request message
     add  5517459   wslua: Fix memleak of unregistered ProtoField strings


Summary of changes:
 debian/libwireshark0.symbols   |   1 +
 epan/proto.c                   | 172 +++++++++++++++++++++--------------------
 epan/proto.h                   |   7 ++
 epan/wslua/wslua_proto.c       |   1 +
 epan/wslua/wslua_proto_field.c |   3 +-
 test/lua/protofield.lua        |   4 +-
 6 files changed, 103 insertions(+), 85 deletions(-)